CWE-404: Improper Resource Shutdown or Release

Code examples

Illustrative examples from MITRE showing how the weakness appears in code.

The following method never closes the new file handle. Given enough time, the Finalize() method for BufferReader should eventually call Close(), but there is no guarantee as to how long this action will take. In fact, there is no guarantee that Finalize() will ever be invoked. In a busy environment, the Operating System could use up all of the available file handles before the Close() function is called.

Vulnerable example

java

private void processFile(string fName)

Safe example

java

private void processFile(string fName)

The good code example simply adds an explicit call to the Close() function when the system is done using the file. Within a simple example such as this the problem is easy to see and fix. In a real system, the problem may be considerably more obscure.

This code attempts to open a connection to a database and catches any exceptions that may occur.

Vulnerable example

java

try {

If an exception occurs after establishing the database connection and before the same connection closes, the pool of database connections may become exhausted. If the number of available connections is exceeded, other users cannot access this resource, effectively denying access to the application.

Under normal conditions the following C# code executes a database query, processes the results returned by the database, and closes the allocated SqlConnection object. But if an exception occurs while executing the SQL or processing the results, the SqlConnection object is not closed. If this happens often enough, the database will run out of available cursors and not be able to execute any more SQL queries.

The following C function does not close the file handle it opens if an error occurs. If the process is long-lived, the process can run out of file handles.

Vulnerable example

CWE-404: Improper Resource Shutdown or Release | RadicalNotion.AI

CWE-404: Improper Resource Shutdown or Release

Overview

Real-world CVEs

Common consequences

How it happens

When it is introduced

How to prevent it

How to detect it

Automated Dynamic Analysis

Manual Dynamic Analysis

Automated Static Analysis

Code examples

Illustrative examples

Terminology & mappings

Mapped taxonomies

Attack patterns

Frequently asked questions

What is CWE-404?

What CVEs are caused by CWE-404?

Is CWE-404 part of the OWASP Top 10?

How do you prevent CWE-404?

How is CWE-404 detected?

What are the consequences of CWE-404?

Is CWE-404 actively exploited?

References

Stay ahead of CWE-404

Peer

Can precede

Overview

Real-world CVEs

Common consequences

How it happens

When it is introduced

How to prevent it

How to detect it

Automated Dynamic Analysis

Manual Dynamic Analysis

Automated Static Analysis

Code examples

Illustrative examples

Related weaknesses

Parent

Child

Terminology & mappings

Mapped taxonomies

Attack patterns

Frequently asked questions

What is CWE-404?

What CVEs are caused by CWE-404?

Is CWE-404 part of the OWASP Top 10?

How do you prevent CWE-404?

How is CWE-404 detected?

What are the consequences of CWE-404?

Is CWE-404 actively exploited?

References

Stay ahead of CWE-404

Peer

Can precede